Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1231783003: WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params. (Closed)

Created:
5 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 5 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params. cert and hostname params are coming from System API and both can potentially be null. For CertVerifierBlockAdapter client (web controller) it will be more convenient not to handle a special case with invalid cert and/or hostname. Instead params error will be handled in completionHandler block along with other errors. BUG=462427 Committed: https://crrev.com/9b0d2bc32bdebafc620ec86e7aae04d079942fc4 Cr-Commit-Position: refs/heads/master@{#338517}

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M ios/web/net/cert_verifier_block_adapter.h View 1 chunk +3 lines, -1 line 0 comments Download
M ios/web/net/cert_verifier_block_adapter.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Eugene But (OOO till 7-30)
5 years, 5 months ago (2015-07-10 20:00:29 UTC) #2
stuartmorgan
lgtm
5 years, 5 months ago (2015-07-13 16:35:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231783003/40001
5 years, 5 months ago (2015-07-13 16:37:03 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-13 16:45:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 16:46:48 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9b0d2bc32bdebafc620ec86e7aae04d079942fc4
Cr-Commit-Position: refs/heads/master@{#338517}

Powered by Google App Engine
This is Rietveld 408576698