ios/web/net/cert_verifier_block_adapter.h - Issue 1231783003: WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/net/cert_verifier_block_adapter.h

Issue 1231783003: WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/net/cert_verifier_block_adapter.h

diff --git a/ios/web/net/cert_verifier_block_adapter.h b/ios/web/net/cert_verifier_block_adapter.h

index 96e07beae54dcb57e66b645daae603ce88b12128..ee9829e68c4db76564129da3192602ef7b3d9b6c 100644

--- a/ios/web/net/cert_verifier_block_adapter.h

+++ b/ios/web/net/cert_verifier_block_adapter.h

@@ -27,7 +27,9 @@ class CertVerifierBlockAdapter {

~CertVerifierBlockAdapter();

// Encapsulates verification parms. |cert| and |hostname| are mandatory, the

- // other params are optional.

+ // other params are optional. If either of mandatory arguments is null or

+ // empty then verification |CompletionHandler| will be called with

+ // ERR_INVALID_ARGUMENT status.

struct Params {

// Constructs Params from X509 cert and hostname, which are mandatory for

// verification.

« no previous file with comments | « no previous file | ios/web/net/cert_verifier_block_adapter.cc » ('j') | no next file with comments »