ios/web/net/cert_verifier_block_adapter.cc - Issue 1231783003: WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/net/cert_verifier_block_adapter.cc

Issue 1231783003: WKWebView: Do not DCHECK on invalid CertVerifierBlockAdapter::Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/net/cert_verifier_block_adapter.cc

diff --git a/ios/web/net/cert_verifier_block_adapter.cc b/ios/web/net/cert_verifier_block_adapter.cc

index 0bdea0603d91c962a0b6856baa5013d8956b8b0b..31901000e9552f2f347735e6937008c50289b3e9 100644

--- a/ios/web/net/cert_verifier_block_adapter.cc

+++ b/ios/web/net/cert_verifier_block_adapter.cc

@@ -70,8 +70,7 @@ CertVerifierBlockAdapter::Params::~Params() {

void CertVerifierBlockAdapter::Verify(

const Params& params,

void (^completion_handler)(scoped_ptr<CertVerifyResult>, int)) {

- DCHECK(params.cert);

- DCHECK(params.hostname.size());

+ DCHECK(completion_handler);

scoped_refptr<VerificationContext> context(

new VerificationContext(params.cert));

@@ -82,7 +81,6 @@ void CertVerifierBlockAdapter::Verify(

params.ocsp_response, params.flags,

params.crl_set.get(), &(context->result),

callback, &(context->request), net_log_);

- DCHECK(status != ERR_INVALID_ARGUMENT);

if (status == ERR_IO_PENDING) {

// Completion handler will be called from |callback| when verification

« no previous file with comments | « ios/web/net/cert_verifier_block_adapter.h ('k') | ios/web/net/cert_verifier_block_adapter_unittest.cc » ('j') | no next file with comments »