Compute if a layer is clipped outside CalcDrawProps

cc/layers/layer_impl.h

Index: cc/layers/layer_impl.h
diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
index 3635a3ab53aea9abef6145aecb6e546732ab13d1..5f226635afb92dcd359792f92e1cd7e7103652af 100644
--- a/cc/layers/layer_impl.h
+++ b/cc/layers/layer_impl.h
@@ -183,6 +183,14 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
     return should_flatten_transform_from_property_tree_;
   }
 
+  void set_is_clipped_from_property_tree(bool is_clipped) {

[Ian Vollick, 2015/07/09 14:26:27]

nit: I see that you've followed the example of
set_should_flatten_transform_from_property_tree, but that function isn't named
correctly either. You should only use hacker case if it's a trivial setter that
can be defined in the header. Since these functions call SetNeedsPushProperties
and are defined in the cc file, they should be camel case.

[jaydasika, 2015/07/09 15:11:49]

It is defined in the header file. I have followed the example of
set_should_flatten_transform_from_property_tree and
set_offset_to_transform_parent, both set and call SetNeedsPushProperties and are
defined inside the header itself. Should I move it to cc?

[Ian Vollick, 2015/07/09 16:42:18]

Hah. I was clearly skimming your patch too quickly. :)
Yes, I'd prefer that these move to the cc and change to camel case, but since
there are many offenders, I'd just leave it as you have it in your current patch
and if we make the change, we can do it for all of these functions at once.

+    is_clipped_from_property_tree_ = is_clipped;
+    SetNeedsPushProperties();
+  }
+  bool is_clipped_from_property_tree() const {
+    return is_clipped_from_property_tree_;
+  }
+
   void UpdatePropertyTreeTransform();
   void UpdatePropertyTreeOpacity();
   void UpdatePropertyTreeScrollOffset();
@@ -393,7 +401,6 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
     return draw_properties_.screen_space_opacity_is_animating;
   }
   bool can_use_lcd_text() const { return draw_properties_.can_use_lcd_text; }
-  bool is_clipped() const { return draw_properties_.is_clipped; }
   gfx::Rect clip_rect() const { return draw_properties_.clip_rect; }
   gfx::Rect drawable_content_rect() const {
     return draw_properties_.drawable_content_rect;
@@ -764,6 +771,7 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
   bool double_sided_ : 1;
   bool should_flatten_transform_ : 1;
   bool should_flatten_transform_from_property_tree_ : 1;
+  bool is_clipped_from_property_tree_ : 1;
 
   // Tracks if drawing-related properties have changed since last redraw.
   bool layer_property_changed_ : 1;