Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: cc/layers/layer_impl.cc

Issue 1231453002: Compute if a layer is clipped outside CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DrawProperties is_clipped removed Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index 3b9a7555653553d680eb7e8a34943dfd50508dae..fc5383a514c5de0d9e764d9eeae23236096d63e1 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -60,6 +60,7 @@ LayerImpl::LayerImpl(LayerTreeImpl* tree_impl,
double_sided_(true),
should_flatten_transform_(true),
should_flatten_transform_from_property_tree_(false),
+ is_clipped_from_property_tree_(false),
layer_property_changed_(false),
masks_to_bounds_(false),
contents_opaque_(false),
@@ -290,7 +291,7 @@ void LayerImpl::ClearRenderSurfaceLayerList() {
void LayerImpl::PopulateSharedQuadState(SharedQuadState* state) const {
state->SetAll(draw_properties_.target_space_transform, bounds(),
draw_properties_.visible_layer_rect, draw_properties_.clip_rect,
- draw_properties_.is_clipped, draw_properties_.opacity,
+ is_clipped_from_property_tree_, draw_properties_.opacity,
draw_properties_.blend_mode, sorting_context_id_);
}
@@ -305,7 +306,7 @@ void LayerImpl::PopulateScaledSharedQuadState(SharedQuadState* state,
scaled_visible_layer_rect.Intersect(gfx::Rect(scaled_bounds));
state->SetAll(scaled_draw_transform, scaled_bounds, scaled_visible_layer_rect,
- draw_properties().clip_rect, draw_properties().is_clipped,
+ draw_properties().clip_rect, is_clipped_from_property_tree_,
draw_properties().opacity, draw_properties().blend_mode,
sorting_context_id_);
}
@@ -546,6 +547,7 @@ void LayerImpl::PushPropertiesTo(LayerImpl* layer) {
layer->SetShouldFlattenTransform(should_flatten_transform_);
layer->set_should_flatten_transform_from_property_tree(
should_flatten_transform_from_property_tree_);
+ layer->set_is_clipped_from_property_tree(is_clipped_from_property_tree_);
layer->SetUseParentBackfaceVisibility(use_parent_backface_visibility_);
layer->SetTransformAndInvertibility(transform_, transform_is_invertible_);

Powered by Google App Engine
This is Rietveld 408576698