cc/layers/picture_layer_impl_unittest.cc - Issue 1231453002: Compute if a layer is clipped outside CalcDrawProps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 1231453002: Compute if a layer is clipped outside CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DrawProperties is_clipped removed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl_unittest.cc

diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc

index a4c5298a8e6ebd73f2698af678ad0cbb67b7c0dc..ca8285ea930b0fc8e6488751984bc72315c8858f 100644

--- a/cc/layers/picture_layer_impl_unittest.cc

+++ b/cc/layers/picture_layer_impl_unittest.cc

@@ -1323,8 +1323,10 @@ TEST_F(PictureLayerImplTest, HugeMasksGetScaledDown) {

pending_layer_->SetMaskLayer(mask_ptr.Pass());

pending_layer_->SetHasRenderSurface(true);

+ host_impl_.pending_tree()->BuildPropertyTreesForTesting();

host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));

bool update_lcd_text = false;

+ host_impl_.pending_tree()->BuildPropertyTreesForTesting();

ajuma 2015/07/09 14:50:15 Do we need to rebuild property trees again? (Has a

jaydasika 2015/07/09 15:11:49 Done. Its not required here.

host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);

FakePictureLayerImpl* pending_mask =

@@ -1452,8 +1454,10 @@ TEST_F(PictureLayerImplTest, ScaledMaskLayer) {

pending_layer_->SetMaskLayer(mask_ptr.Pass());

pending_layer_->SetHasRenderSurface(true);

+ host_impl_.pending_tree()->BuildPropertyTreesForTesting();

host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));

bool update_lcd_text = false;

+ host_impl_.pending_tree()->BuildPropertyTreesForTesting();

ajuma 2015/07/09 14:50:15 Here too, do we need to rebuild again?

jaydasika 2015/07/09 15:11:49 Done. Not required here too

host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);

FakePictureLayerImpl* pending_mask =

« cc/layers/layer_impl.h ('K') | « cc/layers/layer_impl_unittest.cc ('k') | cc/layers/video_layer_impl.cc » ('j') | cc/trees/layer_tree_host_common.cc » ('J')