Compute if a layer is clipped outside CalcDrawProps

cc/layers/layer_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_IMPL_H_
 #define CC_LAYERS_LAYER_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 165 matching lines @@
   }
 
   void set_should_flatten_transform_from_property_tree(bool should_flatten) {
     should_flatten_transform_from_property_tree_ = should_flatten;
     SetNeedsPushProperties();
   }
   bool should_flatten_transform_from_property_tree() const {
     return should_flatten_transform_from_property_tree_;
   }
 
+  void set_is_clipped_from_property_tree(bool is_clipped) {

[Ian Vollick, 2015/07/09 14:26:27]

nit: I see that you've followed the example of
set_should_flatten_transform_from_property_tree, but that function isn't named
correctly either. You should only use hacker case if it's a trivial setter that
can be defined in the header. Since these functions call SetNeedsPushProperties
and are defined in the cc file, they should be camel case.

[jaydasika, 2015/07/09 15:11:49]

It is defined in the header file. I have followed the example of
set_should_flatten_transform_from_property_tree and
set_offset_to_transform_parent, both set and call SetNeedsPushProperties and are
defined inside the header itself. Should I move it to cc?

[Ian Vollick, 2015/07/09 16:42:18]

Hah. I was clearly skimming your patch too quickly. :)
Yes, I'd prefer that these move to the cc and change to camel case, but since
there are many offenders, I'd just leave it as you have it in your current patch
and if we make the change, we can do it for all of these functions at once.

+    is_clipped_from_property_tree_ = is_clipped;
+    SetNeedsPushProperties();
+  }
+  bool is_clipped_from_property_tree() const {
+    return is_clipped_from_property_tree_;
+  }
+
   void UpdatePropertyTreeTransform();
   void UpdatePropertyTreeOpacity();
   void UpdatePropertyTreeScrollOffset();
 
   // For compatibility with Layer.
   bool has_render_surface() const { return !!render_surface(); }
 
   void SetNumDescendantsThatDrawContent(int num_descendants);
   void SetClipParent(LayerImpl* ancestor);
 
@@ skipping 190 matching lines @@
   bool draw_transform_is_animating() const {
     return draw_properties_.target_space_transform_is_animating;
   }
   bool screen_space_transform_is_animating() const {
     return draw_properties_.screen_space_transform_is_animating;
   }
   bool screen_space_opacity_is_animating() const {
     return draw_properties_.screen_space_opacity_is_animating;
   }
   bool can_use_lcd_text() const { return draw_properties_.can_use_lcd_text; }
-  bool is_clipped() const { return draw_properties_.is_clipped; }
   gfx::Rect clip_rect() const { return draw_properties_.clip_rect; }
   gfx::Rect drawable_content_rect() const {
     return draw_properties_.drawable_content_rect;
   }
   gfx::Rect visible_layer_rect() const {
     return draw_properties_.visible_layer_rect;
   }
   LayerImpl* render_target() {
     DCHECK(!draw_properties_.render_target ||
            draw_properties_.render_target->render_surface());
@@ skipping 350 matching lines @@
   static_assert(SCROLL_BLOCKS_ON_MAX < (1 << 3), "ScrollBlocksOn too big");
   ScrollBlocksOn scroll_blocks_on_ : 3;
 
   bool user_scrollable_horizontal_ : 1;
   bool user_scrollable_vertical_ : 1;
   bool stacking_order_changed_ : 1;
   // Whether the "back" of this layer should draw.
   bool double_sided_ : 1;
   bool should_flatten_transform_ : 1;
   bool should_flatten_transform_from_property_tree_ : 1;
+  bool is_clipped_from_property_tree_ : 1;
 
   // Tracks if drawing-related properties have changed since last redraw.
   bool layer_property_changed_ : 1;
 
   bool masks_to_bounds_ : 1;
   bool contents_opaque_ : 1;
   bool is_root_for_isolated_group_ : 1;
   bool use_parent_backface_visibility_ : 1;
   bool draw_checkerboard_for_missing_tiles_ : 1;
   bool draws_content_ : 1;
@@ skipping 84 matching lines @@
   bool visited_;
   bool layer_or_descendant_is_drawn_;
   bool sorted_for_recursion_;
 
   DISALLOW_COPY_AND_ASSIGN(LayerImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_IMPL_H_