Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1230023011: Clean up dead xfermode opts code. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up dead xfermode opts code. Now that SK_SUPPORT_LEGACY_XFERMODES is unused, tons of code becomes dead. Nothing is needed in opts/ anymore for x86. We still do runtime NEON detection, which just duplicates Sk4pxXfermode. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/54f313ccb8eba45954fe0a45092433cbf739b053

Patch Set 1 #

Patch Set 2 : remove guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1691 lines) Patch
M gyp/opts.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/core/Sk4pxXfermode.h View 1 3 chunks +1 line, -2 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
D src/opts/SkXfermode_opts_SSE2.h View 1 chunk +0 lines, -35 lines 0 comments Download
D src/opts/SkXfermode_opts_SSE2.cpp View 1 chunk +0 lines, -530 lines 0 comments Download
M src/opts/SkXfermode_opts_arm.cpp View 1 chunk +10 lines, -15 lines 0 comments Download
D src/opts/SkXfermode_opts_arm_neon.h View 1 chunk +0 lines, -39 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +4 lines, -1023 lines 0 comments Download
M src/opts/SkXfermode_opts_none.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230023011/20001
5 years, 5 months ago (2015-07-17 19:24:32 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-17 19:31:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230023011/20001
5 years, 5 months ago (2015-07-20 14:07:04 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 14:14:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/54f313ccb8eba45954fe0a45092433cbf739b053

Powered by Google App Engine
This is Rietveld 408576698