Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: src/opts/SkXfermode_opts_arm.cpp

Issue 1230023011: Clean up dead xfermode opts code. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove guard Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/opts/SkXfermode_opts_SSE2.cpp ('k') | src/opts/SkXfermode_opts_arm_neon.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/opts/SkXfermode_opts_arm.cpp
diff --git a/src/opts/SkXfermode_opts_arm.cpp b/src/opts/SkXfermode_opts_arm.cpp
index dd09551ae8ad76470b725e878e7f382d5045ae7c..05c330fe8146c77d4558a9c1a3c0bc2402c15ce7 100644
--- a/src/opts/SkXfermode_opts_arm.cpp
+++ b/src/opts/SkXfermode_opts_arm.cpp
@@ -9,25 +9,20 @@
#include "SkXfermode_proccoeff.h"
#include "SkUtilsArm.h"
-extern SkProcCoeffXfermode* SkPlatformXfermodeFactory_impl_neon(const ProcCoeff& rec,
- SkXfermode::Mode mode);
+// If we find we do have NEON, we'll call this method from SkXfermodes_opts_arm_neon.cpp.
+SkProcCoeffXfermode* SkPlatformXfermodeFactory_impl_neon(const ProcCoeff& rec,
+ SkXfermode::Mode mode);
-extern SkXfermodeProc SkPlatformXfermodeProcFactory_impl_neon(SkXfermode::Mode mode);
-
-SkProcCoeffXfermode* SkPlatformXfermodeFactory_impl(const ProcCoeff& rec,
- SkXfermode::Mode mode) {
+// If we don't have NEON, we'll call this method and return NULL.
+SkProcCoeffXfermode* SkPlatformXfermodeFactory_impl(const ProcCoeff& rec, SkXfermode::Mode mode);
+SkProcCoeffXfermode* SkPlatformXfermodeFactory_impl(const ProcCoeff& rec, SkXfermode::Mode mode) {
return NULL;
}
-SkXfermodeProc SkPlatformXfermodeProcFactory_impl(SkXfermode::Mode mode) {
- return NULL;
-}
-
-SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec,
- SkXfermode::Mode mode) {
+SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec, SkXfermode::Mode mode);
+SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec, SkXfermode::Mode mode) {
return SK_ARM_NEON_WRAP(SkPlatformXfermodeFactory_impl)(rec, mode);
}
-SkXfermodeProc SkPlatformXfermodeProcFactory(SkXfermode::Mode mode) {
- return SK_ARM_NEON_WRAP(SkPlatformXfermodeProcFactory_impl)(mode);
-}
+SkXfermodeProc SkPlatformXfermodeProcFactory(SkXfermode::Mode mode);
+SkXfermodeProc SkPlatformXfermodeProcFactory(SkXfermode::Mode mode) { return NULL; }
« no previous file with comments | « src/opts/SkXfermode_opts_SSE2.cpp ('k') | src/opts/SkXfermode_opts_arm_neon.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698