Merge AutocompleteTextfield views::Textfield subclass into OmniboxView.

Merge AutocompleteTextfield views::Textfield subclass into OmniboxView.

Simple cleanup while I'm working on solving the related issues. 
Merge AutocompleteTextfield views::Textfield subclass into OmniboxView.
Reorder OVERRIDEs to match views::View, cleanup TODOs. 
Inline DoCopyText, Handle* functions, and LocationEntryFocusable functions. 
Remove redundant VIEW_ID_AUTOCOMPLETE in favor of VIEW_ID_OMNIBOX.

TODO(msw): Consolidate RemoveBorder with set_border() in Init().
TODO(msw): Compare selection/text length, not content in IsSelectAll().
TODO(msw): Return values from Textfield::GetSelectedRange/GetSelectionModel.

BUG=134701, 176708
TEST=No observable omnibox changes, especially CrOS (and Win with --enable-views-textfield).
R=pkasting@chromium.org,oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183146

[msw, 2013-02-18 01:46:15]

Hey Peter and Oshima, please take a look; thanks!

[Peter Kasting, 2013-02-18 18:57:47]

LGTM

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:195: // OmniboxViewViews,
views::View implementation:
Nit: Again, we don't directly override View.

Personally, I'm not a fan of these sorts of dividers between the different
blocks of virtual function implementations anyway.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:485:
model()->StartAutocomplete(!sel.is_empty(),
Nit: Each line with arguments should have the arguments starting at the same
horizontal position

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:612:
parent->AddChildView(this);
Can we nuke this function entirely now?  Seems like callers could just do the
AddChildView() call directly.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:634: if
(model()->is_keyword_hint() || model()->keyword().empty())
Nit: I wouldn't mind just combining these three conditionals.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.h (left):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.h:38: // Instant.
Are these all fixed, then?

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.h (right):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.h:58: // views::View:
Nit: We don't directly override View, perhaps this should be "//
views::Textfield:"

[msw, 2013-02-18 20:58:21]

Done; landing; thanks for the quick review!

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:195: // OmniboxViewViews,
views::View implementation:
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Nit: Again, we don't directly override View.
> 
> Personally, I'm not a fan of these sorts of dividers between the different
> blocks of virtual function implementations anyway.

I'm not a big fan either, but I fixed it rather than deleting them throughout.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:485:
model()->StartAutocomplete(!sel.is_empty(),
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Nit: Each line with arguments should have the arguments starting at the same
> horizontal position

Done.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:612:
parent->AddChildView(this);
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Can we nuke this function entirely now?  Seems like callers could just do the
> AddChildView() call directly.

I'll try this in a followup, OmniboxViewWin::AddToView isn't as straightforward.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:634: if
(model()->is_keyword_hint() || model()->keyword().empty())
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Nit: I wouldn't mind just combining these three conditionals.

Done.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.h (left):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.h:38: // Instant.
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Are these all fixed, then?

All of these are supported except perhaps Instant, I'll leave that note.

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
File chrome/browser/ui/views/omnibox/omnibox_view_views.h (right):

https://codereview.chromium.org/12299003/diff/3006/chrome/browser/ui/views/om...
chrome/browser/ui/views/omnibox/omnibox_view_views.h:58: // views::View:
On 2013/02/18 18:57:47, Peter Kasting wrote:
> Nit: We don't directly override View, perhaps this should be "//
> views::Textfield:"

Done.

[commit-bot: I haz the power, 2013-02-18 20:58:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12299003/6032

[commit-bot: I haz the power, 2013-02-18 22:55:26]

Change committed as 183146