chrome/browser/ui/cocoa/view_id_util_browsertest.mm - Issue 12299003: Merge AutocompleteTextfield views::Textfield subclass into OmniboxView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 12299003: Merge AutocompleteTextfield views::Textfield subclass into OmniboxView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

index 3cef6bb6b167bb80af681282b342ed27ab88c372..910032e3d501c5ba2fc3060e04e611fac7784a51 100644

--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

@@ -68,7 +68,6 @@ class ViewIDTest : public InProcessBrowserTest {

for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {

// Mac implementation does not support following ids yet.

if (i == VIEW_ID_STAR_BUTTON ||

- i == VIEW_ID_AUTOCOMPLETE ||

i == VIEW_ID_CONTENTS_SPLIT ||

i == VIEW_ID_FEEDBACK_BUTTON ||

i == VIEW_ID_OMNIBOX ||

« no previous file with comments | « no previous file | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc » ('j') | no next file with comments »