chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc - Issue 12299003: Merge AutocompleteTextfield views::Textfield subclass into OmniboxView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 12299003: Merge AutocompleteTextfield views::Textfield subclass into OmniboxView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

index b3103dbc5f0c703dd425fd7a054c8b45b9ecca2f..895e67b3ac17edb969c6160c665aebee0e66528b 100644

--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

@@ -407,7 +407,7 @@ void OmniboxViewGtk::Init() {

content::Source<ThemeService>(theme_service_));

theme_service_->InitThemesFor(this);

- ViewIDUtil::SetID(GetNativeView(), VIEW_ID_AUTOCOMPLETE);

+ ViewIDUtil::SetID(GetNativeView(), VIEW_ID_OMNIBOX);

}

void OmniboxViewGtk::HandleHierarchyChanged(GtkWidget* sender,

« no previous file with comments | « chrome/browser/ui/cocoa/view_id_util_browsertest.mm ('k') | chrome/browser/ui/gtk/view_id_util.cc » ('j') | no next file with comments »