Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229613002: Thread GrShaderDataManager through Image filters (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@GrShaderDataManager2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Thread GrShaderDataManager through Image filters TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/85ff25e8d905502ec09d057ecc6245f487bf94ce

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M include/core/SkImageFilter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1213613016 Patch 40001

Dependent Patchsets:

Issue 1215643006 Patch 40001

Messages

Total messages: 11 (5 generated)
joshualitt
more threading
5 years, 5 months ago (2015-07-08 14:51:31 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/1229613002/diff/20001/include/effects/SkMagnifierImageFilter.h File include/effects/SkMagnifierImageFilter.h (right): https://codereview.chromium.org/1229613002/diff/20001/include/effects/SkMagnifierImageFilter.h#newcode25 include/effects/SkMagnifierImageFilter.h:25: rm virtual ? https://codereview.chromium.org/1229613002/diff/20001/include/effects/SkMagnifierImageFilter.h#newcode28 include/effects/SkMagnifierImageFilter.h:28: #if ...
5 years, 5 months ago (2015-07-08 15:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229613002/40001
5 years, 5 months ago (2015-07-08 15:53:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/928)
5 years, 5 months ago (2015-07-08 15:54:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229613002/40001
5 years, 5 months ago (2015-07-08 15:55:52 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 16:10:07 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/85ff25e8d905502ec09d057ecc6245f487bf94ce

Powered by Google App Engine
This is Rietveld 408576698