Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213613016: More threading of GrShaderDataManager (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@GrShaderDataManager
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M include/core/SkColorFilter.h View 2 chunks +3 lines, -1 line 0 comments Download
M include/effects/SkColorCubeFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkModeColorFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1229613002 Patch 20001
Issue 1229613002 Patch 40001

Messages

Total messages: 15 (7 generated)
joshualitt
part 2, ptal
5 years, 5 months ago (2015-07-08 13:53:18 UTC) #2
robertphillips
lgtm
5 years, 5 months ago (2015-07-08 14:03:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213613016/20001
5 years, 5 months ago (2015-07-08 14:05:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1824) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 14:06:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213613016/40001
5 years, 5 months ago (2015-07-08 14:50:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/922)
5 years, 5 months ago (2015-07-08 14:51:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213613016/40001
5 years, 5 months ago (2015-07-08 14:52:21 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 14:58:21 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2cff176fa25e962f7ae53ebeefa833f0eed276cc

Powered by Google App Engine
This is Rietveld 408576698