Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229113003: Remove some unneeded DEPS from //sky (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove some unneeded DEPS from //sky We no longer actually need to depend on this code. It's cleaner if we don't list these dependencies. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f3563a5c968cdc68c6eff7ce9a6c9c7c847b3a7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5446 lines) Patch
M sky/engine/bindings/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/script/dart_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 6 chunks +0 lines, -17 lines 0 comments Download
D sky/engine/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +0 lines, -145 lines 0 comments Download
D sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +0 lines, -573 lines 0 comments Download
D sky/engine/platform/graphics/Canvas2DLayerManager.h View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/platform/graphics/Canvas2DLayerManager.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsTypes3D.h View 1 chunk +0 lines, -61 lines 0 comments Download
M sky/engine/platform/graphics/ImageBuffer.h View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/platform/graphics/ImageBuffer.cpp View 2 chunks +0 lines, -73 lines 0 comments Download
M sky/engine/platform/graphics/ImageBufferSurface.h View 2 chunks +0 lines, -2 lines 0 comments Download
D sky/engine/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +0 lines, -305 lines 0 comments Download
D sky/engine/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +0 lines, -1049 lines 0 comments Download
D sky/engine/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +0 lines, -678 lines 0 comments Download
D sky/engine/platform/graphics/gpu/Extensions3DUtil.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D sky/engine/platform/graphics/gpu/WebGLImageBufferSurface.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/platform/graphics/gpu/WebGLImageBufferSurface.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/platform/graphics/gpu/WebGLImageConversion.h View 1 chunk +0 lines, -168 lines 0 comments Download
D sky/engine/platform/graphics/gpu/WebGLImageConversion.cpp View 1 chunk +0 lines, -1778 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 04:44:36 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-14 05:17:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f3563a5c968cdc68c6eff7ce9a6c9c7c847b3a7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698