Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1228923002: Revert vector icon CLs. (Closed)

Created:
5 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, tfarina, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_aide_oobe_completion
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Revert vector icon CLs. This reverts the following commits: ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android." 5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time." 33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets." Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which is one of the suspects for having broken browser_tests on Mac builders: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232 http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313 Log output: NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1): [ RUN ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 [7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled. [7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure Value of: [color redComponent] Actual: 0.952941 Expected: 0 ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure Value of: [color greenComponent] Actual: 0.952941 Expected: 0 ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure Value of: [color blueComponent] Actual: 0.952941 Expected: 1 ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure Value of: [color redComponent] Actual: 0.952941 Expected: 1 ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure Value of: [color greenComponent] Actual: 0.952941 Expected: 0 ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure Value of: [color blueComponent] Actual: 0.952941 Expected: 0 [ FAILED ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms) BUG=508389 TBR=estade@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/17399fb2b0a5fcba7c2dcb76ab2c597e6cf7c0db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -495 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -3 lines 0 comments Download
D chrome/browser/resources/help/check_circle.svg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/help/help_content.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/BUILD.gn View 3 chunks +0 lines, -33 lines 0 comments Download
M ui/gfx/gfx.gyp View 2 chunks +1 line, -37 lines 0 comments Download
D ui/gfx/paint_vector_icon.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/gfx/paint_vector_icon.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D ui/gfx/vector_icons.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/gfx/vector_icons/aggregate_vector_icons.py View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/gfx/vector_icons/check_circle.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/gfx/vector_icons/photo_camera.icon View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gfx/vector_icons/vector_icons.cc.template View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/gfx/vector_icons/vector_icons_public.h.template View 1 chunk +0 lines, -20 lines 0 comments Download
A ui/resources/default_100_percent/common/checkmark.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/checkmark.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/image_view.h View 4 chunks +5 lines, -18 lines 0 comments Download
M ui/views/controls/image_view.cc View 6 chunks +9 lines, -22 lines 0 comments Download
M ui/views/controls/throbber.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/throbber.cc View 3 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mattias Nissler (ping if slow)
Committed patchset #1 (id:1) manually as 17399fb2b0a5fcba7c2dcb76ab2c597e6cf7c0db.
5 years, 5 months ago (2015-07-09 09:35:58 UTC) #1
Mattias Nissler (ping if slow)
5 years, 5 months ago (2015-07-09 11:32:13 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1231843002/ by mnissler@chromium.org.

The reason for reverting is: Reverting the revert - it turned out the failures
weren't caused by the reverted CLs, but a bot configuration change happening at
the same time: https://codereview.chromium.org/1212443005.

Powered by Google App Engine
This is Rietveld 408576698