Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: ui/views/controls/throbber.cc

Issue 1228923002: Revert vector icon CLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge_aide_oobe_completion
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/throbber.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/throbber.cc
diff --git a/ui/views/controls/throbber.cc b/ui/views/controls/throbber.cc
index 635ff88a0bb12128d38d4db13b458ed804da64ac..9ecdbd7303236fe9870900ce12a67147ba30c205 100644
--- a/ui/views/controls/throbber.cc
+++ b/ui/views/controls/throbber.cc
@@ -10,8 +10,6 @@
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/paint_throbber.h"
-#include "ui/gfx/paint_vector_icon.h"
-#include "ui/gfx/vector_icons_public.h"
#include "ui/native_theme/common_theme.h"
#include "ui/native_theme/native_theme.h"
#include "ui/resources/grit/ui_resources.h"
@@ -19,14 +17,7 @@
namespace views {
-// The default diameter of a Throbber. If you change this, also change
-// kCheckmarkDipSize.
-static const int kDefaultDiameter = 16;
-// The size of the checkmark, in DIP. This magic number matches the default
-// diamater plus padding inherent in the checkmark SVG.
-static const int kCheckmarkDipSize = 18;
-
-Throbber::Throbber() : checked_(false) {
+Throbber::Throbber() : checked_(false), checkmark_(nullptr) {
}
Throbber::~Throbber() {
@@ -61,23 +52,28 @@ void Throbber::SetChecked(bool checked) {
}
gfx::Size Throbber::GetPreferredSize() const {
+ const int kDefaultDiameter = 16;
return gfx::Size(kDefaultDiameter, kDefaultDiameter);
}
void Throbber::OnPaint(gfx::Canvas* canvas) {
- SkColor color = GetNativeTheme()->GetSystemColor(
- ui::NativeTheme::kColorId_ThrobberSpinningColor);
-
if (!IsRunning()) {
if (checked_) {
- canvas->Translate(gfx::Vector2d((width() - kCheckmarkDipSize) / 2,
- (height() - kCheckmarkDipSize) / 2));
- gfx::PaintVectorIcon(canvas, gfx::VectorIconId::CHECK_CIRCLE,
- kCheckmarkDipSize, color);
+ if (!checkmark_) {
+ checkmark_ = ui::ResourceBundle::GetSharedInstance()
+ .GetImageNamed(IDR_CHECKMARK)
+ .ToImageSkia();
+ }
+
+ int checkmark_x = (width() - checkmark_->width()) / 2;
+ int checkmark_y = (height() - checkmark_->height()) / 2;
+ canvas->DrawImageInt(*checkmark_, checkmark_x, checkmark_y);
}
return;
}
+ SkColor color = GetNativeTheme()->GetSystemColor(
+ ui::NativeTheme::kColorId_ThrobberSpinningColor);
base::TimeDelta elapsed_time = base::TimeTicks::Now() - start_time_;
gfx::PaintThrobberSpinning(canvas, GetContentsBounds(), color, elapsed_time);
}
« no previous file with comments | « ui/views/controls/throbber.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698