Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212443005: reland #1: Set mac_min_sdk=10.10 on chromium.mac bots (Closed)

Created:
5 years, 5 months ago by erikchen
Modified:
5 years, 5 months ago
Reviewers:
smut, smut
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

reland #1: Set mac_min_sdk=10.10 on chromium.mac bots Original author: smut@ >BUG=463170 > >Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295942 > >patch from issue 1201213003 at patchset 20001 (http://crrev.com/1201213003#ps20001) BUG=463170 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295949

Patch Set 1 : Original CL. #

Patch Set 2 : Updated CL to prevent build configs from being used by testers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_mac.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_summary.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_swarming_error.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_fyi_link_against_10_10.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
smut: Please review.
5 years, 5 months ago (2015-07-07 22:32:56 UTC) #2
smut
lgtm
5 years, 5 months ago (2015-07-08 19:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212443005/20001
5 years, 5 months ago (2015-07-08 20:01:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295949
5 years, 5 months ago (2015-07-08 20:04:59 UTC) #6
Mattias Nissler (ping if slow)
5 years, 5 months ago (2015-07-09 10:10:22 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1227903003/ by mnissler@chromium.org.

The reason for reverting is: Looks like this broke some tests on Mac bots, see
http://crbug.com/508389.

Powered by Google App Engine
This is Rietveld 408576698