Removed and replaced outdated mac-specific files and references.

Removed and replaced outdated mac-specific files and references
that weren't caught in previous patches.

BUG=415302
Committed: https://crrev.com/9240727ec7f769727e99cff42539976f3c6c1f43
Cr-Commit-Position: refs/heads/master@{#342269}

[dylanking, 2015-07-07 02:30:55]

dylanking@google.com changed reviewers:
+ aurimas@chromium.org, rouslan@chromium.org

[dylanking, 2015-07-07 02:30:55]

Depends on https://codereview.chromium.org/1204293003

It's (hopefully) not as big as it looks.  Most of it is just replacing "mac" or
"MACOSX" references with "platform" references.  

There's some other miscellaneous, blanket style changes that I threw in this CL
because this one has all of the code, whereas previous ones only have some.

[groby-ooo-7-16, 2015-07-07 21:41:28]

NOT LGTM - misses platform_engine.[cc|h]

Also, what platform is platform_engine supposed to be for?

(rouslan, feel free to override my NOT if I'm missing something - don't know
when I'm back in contact again, so please don't wait for me)

[dylanking, 2015-07-07 21:55:03]

On 2015/07/07 at 21:41:28, groby wrote:
> NOT LGTM - misses platform_engine.[cc|h]
> 
> Also, what platform is platform_engine supposed to be for?
> 
> (rouslan, feel free to override my NOT if I'm missing something - don't know
when I'm back in contact again, so please don't wait for me)

platform_engine.[cc|h] shouldn't have any mac-specific redundancies to remove
(if that's what you're referring to).  

It is simply a renamed cocoa_spelling_engine_mac.[cc|h], at least for now.  The
plan, and overall point of this CL, is to generalize many of the mac-specific
files to be more generic so that they can be extended to support future cases
where a platform's built-in spellchecker is desired (as opposed to hunspell). 
The immediate goal and motivator behind this is so that we can use Android's
built-in spellchecker, and reuse the existing codepaths that are in place for
OSX's built-in spellchecker support.  

I could add a comment at the top of platform_engine.[cc|h] to explain some of
this if reviewers think that's necessary.

[dylanking, 2015-07-23 00:13:32]

dylanking@google.com changed reviewers:
+ groby@chromium.org

[dylanking, 2015-07-23 09:12:04]

The CQ bit was checked by dylanking@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-23 09:12:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227553002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1227553002/240001

[commit-bot: I haz the power, 2015-07-23 09:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 09:12:41]

Dry run: A disapproval has been posted by following reviewers:
groby@chromium.org.
Please make sure to get positive review before another CQ attempt.

[groby-ooo-7-16, 2015-07-25 00:22:45]

I'm missing the rename in the .gypi/.gn that defines this?

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
File chrome/browser/spellchecker/spellcheck_message_filter.h (right):

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
chrome/browser/spellchecker/spellcheck_message_filter.h:36: #if
!defined(USE_PLATFORM_SPELLCHECKER)
This is not about a platform spell checker, this is about having a browser side
spell checker.

[dylanking, 2015-07-25 00:28:14]

Here's the patch that added the preprocessor flag:
https://codereview.chromium.org/1210943008
Let me know if that isn't what you were asking for.

[dylanking, 2015-07-25 00:37:55]

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
File chrome/browser/spellchecker/spellcheck_message_filter.h (right):

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
chrome/browser/spellchecker/spellcheck_message_filter.h:36: #if
!defined(USE_PLATFORM_SPELLCHECKER)
Sorry, I'm not sure, is this a stylistic or functional recommendation?
Right now this will exclude the surrounded code on OSX and Android. I didn't
think that Android would be utilizing the SpellingService, or at least these
three methods.

[groby-ooo-7-16, 2015-07-31 17:29:58]

Sorry for the delay - slipped through my filter. Feel free to ping me on IM (or
reroute to rouslan) if that happens again.

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
File chrome/browser/spellchecker/spellcheck_message_filter.h (right):

https://codereview.chromium.org/1227553002/diff/280001/chrome/browser/spellch...
chrome/browser/spellchecker/spellcheck_message_filter.h:36: #if
!defined(USE_PLATFORM_SPELLCHECKER)
On 2015/07/25 00:37:55, dylanking wrote:
> Sorry, I'm not sure, is this a stylistic or functional recommendation?
> Right now this will exclude the surrounded code on OSX and Android. I didn't
> think that Android would be utilizing the SpellingService, or at least these
> three methods.  

Stylistic recommendation. Because the browser side does not only include the OSX
spell checker, it also includes red underline service.

[dylanking, 2015-08-04 18:20:14]

dylanking@google.com changed reviewers:
- aurimas@chromium.org

[dylanking, 2015-08-04 18:20:15]

Renamed the preprocessor flag in https://codereview.chromium.org/1263423006

[dylanking, 2015-08-04 18:21:38]

On 2015/08/04 at 18:20:15, dylanking wrote:
> Renamed the preprocessor flag in https://codereview.chromium.org/1263423006

Actually just realized the tests probably won't pass until that patch lands. 
Feel free to take a look at this now though.

[groby-ooo-7-16, 2015-08-04 18:41:35]

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
File chrome/renderer/spellchecker/spellcheck.cc (right):

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:363: #if
!defined(USE_BROWSER_SPELLCHECKER)  // OSX and Android use their own spell
checkers
Line length

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:385: #if
!defined(USE_BROWSER_SPELLCHECKER) // OSX and Android don't have
|pending_request_param_|
Ditto

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:396: #if
!defined(USE_BROWSER_SPELLCHECKER)  // Mac and Android use their platform
engines instead.
Ditto.

[dylanking, 2015-08-04 18:49:10]

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
File chrome/renderer/spellchecker/spellcheck.cc (right):

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:363: #if
!defined(USE_BROWSER_SPELLCHECKER)  // OSX and Android use their own spell
checkers
Done.  Thanks!

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:385: #if
!defined(USE_BROWSER_SPELLCHECKER) // OSX and Android don't have
|pending_request_param_|
Done.  Thanks!

https://codereview.chromium.org/1227553002/diff/300001/chrome/renderer/spellc...
chrome/renderer/spellchecker/spellcheck.cc:396: #if
!defined(USE_BROWSER_SPELLCHECKER)  // Mac and Android use their platform
engines instead.
Done.  Thanks!

[groby-ooo-7-16, 2015-08-06 23:45:44]

LGTM

[please use gerrit instead, 2015-08-06 23:47:32]

Patch Set 17 lgtm

[dylanking, 2015-08-06 23:49:13]

The CQ bit was checked by dylanking@google.com

[commit-bot: I haz the power, 2015-08-06 23:50:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227553002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1227553002/320001

[commit-bot: I haz the power, 2015-08-07 02:27:28]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2015-08-07 02:27:58]

Patchset 17 (id:??) landed as
https://crrev.com/9240727ec7f769727e99cff42539976f3c6c1f43
Cr-Commit-Position: refs/heads/master@{#342269}