Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1263423006: Rename spellchecker preprocessor flag (Closed)

Created:
5 years, 4 months ago by dylanking
Modified:
5 years, 4 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename spellchecker preprocessor flag Renamed USE_PLATFORM_SPELLCHECKER preprocessor flag to USE_BROWSER_SPELLCHECKER to more accurately reflect the fact that the browser side contains other services such as red underlines that will be leveraged by any spellchecker. BUG=415302 Committed: https://crrev.com/990eb97f091d9719b2061de67b7e585f6a967d8b Cr-Commit-Position: refs/heads/master@{#341771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M build/common.gypi View 4 chunks +5 lines, -5 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/spellcheck_messages.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
dylanking
+groby@ for owners review of: chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h chrome/browser/spellchecker/spellcheck_message_filter.cc chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc chrome/renderer/spellchecker/hunspell_engine.cc chrome/renderer/spellchecker/spellcheck_provider.cc chrome/renderer/spellchecker/spellcheck_provider.h chrome/renderer/spellchecker/spellcheck_provider_test.cc +jochen@ for ...
5 years, 4 months ago (2015-08-04 01:10:57 UTC) #2
dcheng
Renaming changes in chrome/common/spellcheck_messages.h LGTM
5 years, 4 months ago (2015-08-04 06:21:37 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-04 13:48:21 UTC) #4
groby-ooo-7-16
spellchecker LGTM - thank you for changing this!
5 years, 4 months ago (2015-08-04 17:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263423006/1
5 years, 4 months ago (2015-08-04 18:04:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 19:56:43 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 19:59:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/990eb97f091d9719b2061de67b7e585f6a967d8b
Cr-Commit-Position: refs/heads/master@{#341771}

Powered by Google App Engine
This is Rietveld 408576698