Patch 3: Added files for platform-based spellcheck.

Added files for platform-based spellcheck.

These files are mostly skeleton code at this point.

Also included skeleton Android implementations of these new platform classes.

Enabled spellcheck on Android now that we are using the ChromeSwitch.

BUG=415302

[dylanking, 2015-07-07 02:28:41]

dylanking@google.com changed reviewers:
+ aurimas@chromium.org, rouslan@chromium.org

[dylanking, 2015-07-07 02:28:41]

Depends on https://codereview.chromium.org/1210943008

[groby-ooo-7-16, 2015-07-07 21:45:10]

groby@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2015-07-07 21:45:11]

Ah. Here's the missing file. However, it shouldn't just be called
platform_spelling_engine. Convention for Chrome is that "cocoa"/"mac" is either
reflected in the path or the file name. (Same goes for engines for other
platforms)

[dylanking, 2015-07-07 21:58:48]

On 2015/07/07 at 21:45:11, groby wrote:
> Ah. Here's the missing file. However, it shouldn't just be called
platform_spelling_engine. Convention for Chrome is that "cocoa"/"mac" is either
reflected in the path or the file name. (Same goes for engines for other
platforms)

If we aim to generalize the code so that it can support multiple platforms, how
do you suggest I go about this while maintaining this convention (if possible)? 

One idea I have is to preserve platform_engine.h and then split the
implementation into cocoa_spelling_engine_mac.cc and android_spelling_engine.cc,
or something of the sort.

[aurimas (slooooooooow), 2015-07-09 18:12:52]

It looks reasonable, but you should have groby@ or rouslan@ take a look at this.
Also since we are touching IPC filter code, I would add palmer@ from Chrome
security to take a quick look.

https://chromiumcodereview.appspot.com/1204293003/diff/90001/chrome/browser/s...
File chrome/browser/spellchecker/spellcheck_platform_android.cc (right):

https://chromiumcodereview.appspot.com/1204293003/diff/90001/chrome/browser/s...
chrome/browser/spellchecker/spellcheck_platform_android.cc:70: //  NSString*
NS_lang_to_set = ConvertLanguageCodeToMac(lang_to_set);
Remove the code that does nothing.

[dylanking, 2015-07-09 18:29:31]

Patchset #7 (id:110001) has been deleted

[dylanking, 2015-07-09 18:53:37]

Patchset #7 (id:130001) has been deleted

[dylanking, 2015-07-09 18:58:15]

https://codereview.chromium.org/1204293003/diff/90001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_platform_android.cc (right):

https://codereview.chromium.org/1204293003/diff/90001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_platform_android.cc:70: //  NSString*
NS_lang_to_set = ConvertLanguageCodeToMac(lang_to_set);
Done, along with a bit more comment cleanup in the same file.

[please use gerrit instead, 2015-07-09 19:45:32]

Please split into 3 separate patches as described below.

(Note that spellchecking implementation is a little bit of a mess. So you might
even see functions that are never used. Sorry about that. We're working on
cleaning it up over time.)

https://codereview.chromium.org/1204293003/diff/150001/chrome/browser/spellch...
File chrome/browser/spellchecker/spellcheck_message_filter_platform.h (right):

https://codereview.chromium.org/1204293003/diff/150001/chrome/browser/spellch...
chrome/browser/spellchecker/spellcheck_message_filter_platform.h:60: #endif  //
CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_MESSAGE_FILTER_PLATFORM_H_
Please split this change into a separate patch that does the following:

1) Move spellcheck_message_filter_mac.h -> spellcheck_message_filter_platform.h.

2) Move spellcheck_message_filter_mac.cc ->
spellcheck_message_filter_platform_mac.cc.

3) Copy spellcheck_message_filter_mac.cc ->
spellcheck_message_filter_platform_android.cc with only stub implementations.
There should be no original method implementations remaining, just the method
stubs.

https://codereview.chromium.org/1204293003/diff/150001/chrome/browser/spellch...
File chrome/browser/spellchecker/spellcheck_platform.h (right):

https://codereview.chromium.org/1204293003/diff/150001/chrome/browser/spellch...
chrome/browser/spellchecker/spellcheck_platform.h:112: #endif  //
CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_PLATFORM_H_
Please delete spellcheck_platform_mac.h in the same patch as creating
spellcheck_platform.h. The two source files for this header should be called
spellcheck_platform_android.cc and spellcheck_platform_mac.mm. This should be
done in a separate patch.

https://codereview.chromium.org/1204293003/diff/150001/chrome/renderer/spellc...
File chrome/renderer/spellchecker/platform_engine.h (right):

https://codereview.chromium.org/1204293003/diff/150001/chrome/renderer/spellc...
chrome/renderer/spellchecker/platform_engine.h:22: #endif  //
CHROME_RENDERER_SPELLCHECKER_PLATFORM_ENGINE_H_
Please make a separate patch that moves (not copies)
cocoa_spelling_engine_mac.h/cc into platform_spelling_engine.h/cc.