Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1244443005: Patch 5: Implemented android message filter and platform. (Closed)

Created:
5 years, 5 months ago by dylanking
Modified:
5 years, 4 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@4_remove_mac_redundancies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch 5: Implemented android message filter and platform. Also added a Java class for JNI interfacing. The class is mostly stubs for now. BUG=415302

Patch Set 1 #

Patch Set 2 : Cleaned up SpellCheckerSessionBridge #

Patch Set 3 : Added SpellCheckerSessionBridge.java to chrome_browser.gypi #

Patch Set 4 : Small addition to platform implementation #

Patch Set 5 : Implemented Android spellchecker red underlining #

Total comments: 2

Patch Set 6 : 1:1 SpellingRequest/JavaObject relationship, slow when spammed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -9 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/spellchecker/SpellCheckerSessionBridge.java View 1 2 3 4 5 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform.h View 1 2 3 4 5 2 chunks +40 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc View 1 2 3 4 5 4 chunks +145 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_android.cc View 1 2 3 4 5 4 chunks +55 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1227553002 Patch 320001

Messages

Total messages: 3 (1 generated)
dylanking
Here's the code, it still has copious amounts of logging statements in it and needs ...
5 years, 4 months ago (2015-08-04 21:31:20 UTC) #2
please use gerrit instead
5 years, 4 months ago (2015-08-04 22:04:26 UTC) #3 
https://codereview.chromium.org/1244443005/diff/80001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_platform_android.cc (right):

https://codereview.chromium.org/1244443005/diff/80001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_platform_android.cc:20:
base::Callback<void(const std::vector<SpellCheckResult>&)> callback_;
Don't use shared variables like this, as it will not work with asynchronous
code. Put these vars into the private section of SpellingRequest
(spellcheck_message_filter_platform_android.cc).

https://codereview.chromium.org/1244443005/diff/80001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_platform_android.cc:120:
callback_.Run(check_results);
All this code should be in spellcheck_message_filter_platform_android.cc.

Powered by Google App Engine
This is Rietveld 408576698