Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12259037: Reapply remove setTimeout, take 3. (Closed)

Created:
7 years, 10 months ago by Emily Fortuna
Modified:
7 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply remove setTimeout, take 3. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -399 lines) Patch
M samples/calculator/calculator.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M samples/dartcombat/setup.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/isolate_html/isolate_sample.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M samples/swarm/App.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/SwarmViews.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M samples/swarm/Views.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/base/AnimationScheduler.dart View 5 chunks +15 lines, -13 lines 0 comments Download
M samples/swarm/swarm_ui_lib/base/DomWrapper.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/base/base.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Scrollbar.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/ConveyorView.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M samples/tests/samples/dartcombat/dartcombat_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/layout/layout_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M samples/tests/samples/swarm/swarm_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/Dromaeo.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/third_party/dromaeo/tests/RunnerSuite.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-attr-html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-modify-html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse-html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +75 lines, -34 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +36 lines, -15 lines 0 comments Download
M tests/benchmark_smoke/benchmark_base.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M tests/benchmark_smoke/benchmark_lib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/html/async_window_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/dromaeo_noop/dromaeo_smoke.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/history_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/js_interop_3_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/js_interop_4_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/microtask_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/transition_event_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/window_open_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/src/Timer.dart View 1 chunk +4 lines, -4 lines 0 comments Download
D tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +0 lines, -173 lines 0 comments Download
D tools/dom/templates/html/dartium/impl_Window.darttemplate View 1 chunk +0 lines, -47 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +77 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
Okay, so if I apply those two dartium commits, and then this CL, we should ...
7 years, 10 months ago (2013-02-15 01:33:16 UTC) #1
blois
7 years, 10 months ago (2013-02-15 02:14:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698