Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tests/html/history_test.dart

Issue 12259037: Reapply remove setTimeout, take 3. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/dromaeo_noop/dromaeo_smoke.dart ('k') | tests/html/js_interop_3_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/history_test.dart
diff --git a/tests/html/history_test.dart b/tests/html/history_test.dart
index f2c7c1286cf10f75356c5dfccd508fe878c8ebc6..7ee08cec4b53f50132511e5fd42b31997f5ade0f 100644
--- a/tests/html/history_test.dart
+++ b/tests/html/history_test.dart
@@ -2,6 +2,7 @@ library HistoryTest;
import '../../pkg/unittest/lib/unittest.dart';
import '../../pkg/unittest/lib/html_individual_config.dart';
import 'dart:html';
+import 'dart:async';
main() {
useHtmlIndividualConfiguration();
@@ -42,14 +43,14 @@ main() {
expect(window.location.href.endsWith('dummy2'), isTrue);
// Need to wait a frame or two to let the pushState events occur.
- window.setTimeout(expectAsync0(() {
+ new Timer(const Duration(milliseconds: 100), expectAsync0(() {
window.onPopState.first.then(expectAsync1((_){
expect(window.history.length, length);
expect(window.location.href.endsWith('dummy1'), isTrue);
}));
window.history.back();
- }), 100);
+ }));
}, expectation);
});
« no previous file with comments | « tests/html/dromaeo_noop/dromaeo_smoke.dart ('k') | tests/html/js_interop_3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698