Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: tests/html/window_open_test.dart

Issue 12259037: Reapply remove setTimeout, take 3. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/html/transition_event_test.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 library WindowOpenTest; 1 library WindowOpenTest;
2 import '../../pkg/unittest/lib/unittest.dart'; 2 import '../../pkg/unittest/lib/unittest.dart';
3 import '../../pkg/unittest/lib/html_config.dart'; 3 import '../../pkg/unittest/lib/html_config.dart';
4 import 'dart:html'; 4 import 'dart:html';
5 import 'dart:async';
5 6
6 main() { 7 main() {
7 useHtmlConfiguration(); 8 useHtmlConfiguration();
8 evaluateJavaScript(code) { 9 evaluateJavaScript(code) {
9 final scriptTag = new Element.tag('script'); 10 final scriptTag = new Element.tag('script');
10 scriptTag.innerHtml = code; 11 scriptTag.innerHtml = code;
11 document.body.nodes.add(scriptTag); 12 document.body.nodes.add(scriptTag);
12 } 13 }
13 evaluateJavaScript('(testRunner || layoutTestController).setCanOpenWindows()') ; 14 evaluateJavaScript('(testRunner || layoutTestController).setCanOpenWindows()') ;
14 15
15 test('TwoArgumentVersion', () { 16 test('TwoArgumentVersion', () {
16 Window win = window.open('../resources/pong.html', 'testWindow'); 17 Window win = window.open('../resources/pong.html', 'testWindow');
17 closeWindow(win); 18 closeWindow(win);
18 }); 19 });
19 test('ThreeArgumentVersion', () { 20 test('ThreeArgumentVersion', () {
20 Window win = window.open("resources/pong.html", "testWindow", "scrollbars=ye s,width=75,height=100"); 21 Window win = window.open("resources/pong.html", "testWindow", "scrollbars=ye s,width=75,height=100");
21 closeWindow(win); 22 closeWindow(win);
22 }); 23 });
23 } 24 }
24 25
25 closeWindow(win) { 26 closeWindow(win) {
26 win.close(); 27 win.close();
27 doneHandler() { 28 doneHandler() {
28 if (!win.closed) { 29 if (!win.closed) {
29 window.setTimeout(expectAsync0(doneHandler), 1); 30 new Timer(const Duration(milliseconds: 1), expectAsync0(doneHandler));
30 } 31 }
31 } 32 }
32 window.setTimeout(expectAsync0(doneHandler), 1); 33 new Timer(const Duration(milliseconds: 1), expectAsync0(doneHandler));
33 } 34 }
OLDNEW
« no previous file with comments | « tests/html/transition_event_test.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698