Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: tests/benchmark_smoke/benchmark_smoke_test.dart

Issue 12259037: Reapply remove setTimeout, take 3. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/benchmark_smoke/benchmark_lib.dart ('k') | tests/html/async_window_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/benchmark_smoke/benchmark_smoke_test.dart
diff --git a/tests/benchmark_smoke/benchmark_smoke_test.dart b/tests/benchmark_smoke/benchmark_smoke_test.dart
index 2c46a48544c777cb16ac10b00e2d86152d80e3c4..2e4582767376ec179efd19cae66e894a14056e6c 100644
--- a/tests/benchmark_smoke/benchmark_smoke_test.dart
+++ b/tests/benchmark_smoke/benchmark_smoke_test.dart
@@ -6,6 +6,7 @@ library benchmarksmoketest;
// Tests that benchmark classes used in perf testing are not broken.
import 'benchmark_lib.dart';
+import 'dart:async';
import 'dart:html';
import '../../pkg/unittest/lib/unittest.dart';
import '../../pkg/unittest/lib/html_config.dart';
@@ -13,9 +14,9 @@ import '../../pkg/unittest/lib/html_config.dart';
void main() {
useHtmlConfiguration();
- test('performanceTesting', () {
- window.setTimeout(BENCHMARK_SUITE.runBenchmarks, 0);
- window.setTimeout(expectAsync0(testForCompletion), 0);
+ test('performanceTesting', () {
+ Timer.run(BENCHMARK_SUITE.runBenchmarks);
+ Timer.run(expectAsync0(testForCompletion));
});
}
« no previous file with comments | « tests/benchmark_smoke/benchmark_lib.dart ('k') | tests/html/async_window_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698