Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1225583008: [Feedback] Remove bandwidth from feedback reports. (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Remove bandwidth from feedback reports. Because of the work around issue 506509 which aims to remove ACCESS_WIFI_STATE permission, this rendered NetworkChangeNotifier#getCurrentConnectionType() useless after https://codereview.chromium.org/1226463003 landed. This CL therefore removes the bandwidth from feedback report since they all just indicate 'Infinity' without the permission. BUG=386395 Committed: https://crrev.com/64d7071321341e0f4202f741cc8feac604629aac Cr-Commit-Position: refs/heads/master@{#337521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java View 4 chunks +3 lines, -16 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nyquist
dfalcantara: PTAL
5 years, 5 months ago (2015-07-06 23:07:49 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-06 23:08:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225583008/1
5 years, 5 months ago (2015-07-06 23:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225583008/1
5 years, 5 months ago (2015-07-06 23:15:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 23:54:00 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 23:54:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64d7071321341e0f4202f741cc8feac604629aac
Cr-Commit-Position: refs/heads/master@{#337521}

Powered by Google App Engine
This is Rietveld 408576698