Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java

Issue 1225583008: [Feedback] Remove bandwidth from feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java
index 696460690c013d28691f0fe92fcfb07abeb908ab..c841391bec527573f25adb24d486f3743c8a8751 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java
@@ -43,14 +43,6 @@ public class ConnectivityTask {
static final String CONNECTION_TYPE_KEY = "Connection type";
/**
- * The key for the data describing the bandwidth of the current connection. The data is
- * represented as Mbps.
- * This string is user visible.
- */
- @VisibleForTesting
- static final String CONNECTION_BANDWIDTH_KEY = "Connection bandwidth (Mbps)";
-
- /**
* The key for the data describing whether Chrome was able to successfully connect to the
* HTTP connection check URL using the Chrome network stack.
* This string is user visible.
@@ -155,15 +147,13 @@ public class ConnectivityTask {
private final int mTimeoutMs;
private final long mElapsedTimeMs;
private final int mConnectionType;
- private final double mBandwidthInMbps;
FeedbackData(Map<Type, Integer> connections, int timeoutMs, long elapsedTimeMs,
- int connectionType, double bandwidthInMbps) {
+ int connectionType) {
mConnections = connections;
mTimeoutMs = timeoutMs;
mElapsedTimeMs = elapsedTimeMs;
mConnectionType = connectionType;
- mBandwidthInMbps = bandwidthInMbps;
}
/**
@@ -202,7 +192,6 @@ public class ConnectivityTask {
}
map.put(CONNECTION_CHECK_ELAPSED_KEY, String.valueOf(mElapsedTimeMs));
map.put(CONNECTION_TYPE_KEY, getHumanReadableConnectionType(mConnectionType));
- map.put(CONNECTION_BANDWIDTH_KEY, String.valueOf(mBandwidthInMbps));
return map;
}
}
@@ -313,10 +302,8 @@ public class ConnectivityTask {
}
}
long elapsedTimeMs = SystemClock.elapsedRealtime() - mStartCheckTimeMs;
- NetworkChangeNotifier ncn = NetworkChangeNotifier.getInstance();
- int connectionType = ncn.getCurrentConnectionType();
- double bandwidthInMbps = ncn.getCurrentMaxBandwidthInMbps();
- return new FeedbackData(result, mTimeoutMs, elapsedTimeMs, connectionType, bandwidthInMbps);
+ int connectionType = NetworkChangeNotifier.getInstance().getCurrentConnectionType();
+ return new FeedbackData(result, mTimeoutMs, elapsedTimeMs, connectionType);
}
/**
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698