Remove ACCESS_WIFI_STATE permission from Android builds

Remove ACCESS_WIFI_STATE permission from Android builds

This is no longer needed (possibly never has been) and prevents
automatic updates of old versions of Chrome.

BUG=506509
Committed: https://crrev.com/3485d42792b860902d6311be5080345b94bb8dfe
Cr-Commit-Position: refs/heads/master@{#337409}

[aberent, 2015-07-02 10:40:03]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-02 10:40:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226463003/1

[commit-bot: I haz the power, 2015-07-02 10:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 10:50:17]

Dry run: This issue passed the CQ dry run.

[aberent, 2015-07-02 11:07:48]

aberent@chromium.org changed reviewers:
+ yfriedman@chromium.org

[aberent, 2015-07-02 11:08:30]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-02 11:08:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226463003/20001

[commit-bot: I haz the power, 2015-07-02 11:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 11:19:39]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2015-07-02 11:26:27]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-07-02 11:26:28]

lgtm

[Yaron, 2015-07-06 15:59:18]

lgtm if you've verified that this doesn't break the network connectivity checker

https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
File chrome/android/java/AndroidManifest.xml (left):

https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:25: <uses-permission
android:name="android.permission.ACCESS_WIFI_STATE" />
Will the code mentioned in the team thread crash if this permission isn't
available?

[aberent, 2015-07-06 16:46:22]

On 2015/07/06 15:59:18, Yaron wrote:
> lgtm if you've verified that this doesn't break the network connectivity
checker
> 
>
https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
> File chrome/android/java/AndroidManifest.xml (left):
> 
>
https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
> chrome/android/java/AndroidManifest.xml:25: <uses-permission
> android:name="android.permission.ACCESS_WIFI_STATE" />
> Will the code mentioned in the team thread crash if this permission isn't
> available?

No, it will not crash, see
https://cs.corp.google.com/#clankium/src/net/android/java/src/org/chromium/ne...,
which clearly checks the permission before doing anything that requires it. What
it will do is mean that the bandwidth reported is always the maximum possible
bandwidth for the class of WiFi that is in use (e.g. 54Mb/s for 802.11g).See
NetworkChangeNotifierAutoDetect.getCurrentMaxBandwidthInMbps().

[aberent, 2015-07-06 16:46:43]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2015-07-06 16:47:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226463003/20001

[commit-bot: I haz the power, 2015-07-06 17:05:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-06 17:06:13]

Patchset 2 (id:??) landed as
https://crrev.com/3485d42792b860902d6311be5080345b94bb8dfe
Cr-Commit-Position: refs/heads/master@{#337409}

[nyquist, 2015-07-06 22:38:16]

On 2015/07/06 15:59:18, Yaron wrote:
> lgtm if you've verified that this doesn't break the network connectivity
checker
> 
>
https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
> File chrome/android/java/AndroidManifest.xml (left):
> 
>
https://codereview.chromium.org/1226463003/diff/20001/chrome/android/java/And...
> chrome/android/java/AndroidManifest.xml:25: <uses-permission
> android:name="android.permission.ACCESS_WIFI_STATE" />
> Will the code mentioned in the team thread crash if this permission isn't
> available?

I tried for feedback code, and we just got "Infinity" back instead of a legit
number. Have not investigated further. Will just remove the usage of it in
feedback.

[nyquist, 2015-07-06 23:04:42]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2015-07-06 23:04:42]

Will the follow-up for removing the current functionality that depends on this
(for example NetworkChangeNotifier#getCurrentConnectionType()) be tracked using
the same bug as this?