chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java - Issue 1225583008: [Feedback] Remove bandwidth from feedback reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

Issue 1225583008: [Feedback] Remove bandwidth from feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

index 2dbffda8671c9a34d3bb444a799db9fc761e6e97..4d67136a776ad30024699657c2be96f303765557 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java

@@ -185,10 +185,10 @@ public class ConnectivityTaskTest extends ConnectivityCheckerTestBase {

connectionMap.put(Type.SYSTEM_HTTPS, ConnectivityCheckResult.CONNECTED);

FeedbackData feedback =

- new FeedbackData(connectionMap, 42, 21, ConnectionType.CONNECTION_WIFI, 4.2);

+ new FeedbackData(connectionMap, 42, 21, ConnectionType.CONNECTION_WIFI);

Map<String, String> map = feedback.toMap();

- assertEquals("Should have 7 entries.", 7, map.size());

+ assertEquals("Should have 6 entries.", 6, map.size());

assertTrue(map.containsKey(ConnectivityTask.CHROME_HTTP_KEY));

assertEquals("NOT_CONNECTED", map.get(ConnectivityTask.CHROME_HTTP_KEY));

assertTrue(map.containsKey(ConnectivityTask.CHROME_HTTPS_KEY));

@@ -201,8 +201,6 @@ public class ConnectivityTaskTest extends ConnectivityCheckerTestBase {

assertEquals("21", map.get(ConnectivityTask.CONNECTION_CHECK_ELAPSED_KEY));

assertTrue(map.containsKey(ConnectivityTask.CONNECTION_TYPE_KEY));

assertEquals("WiFi", map.get(ConnectivityTask.CONNECTION_TYPE_KEY));

- assertTrue(map.containsKey(ConnectivityTask.CONNECTION_BANDWIDTH_KEY));

- assertEquals("4.2", map.get(ConnectivityTask.CONNECTION_BANDWIDTH_KEY));

}

private static FeedbackData getResult(final AtomicReference<ConnectivityTask> task) {