Suppress "unused-const-variable" Clang warnings.

Suppress "unused-const-variable" Clang warnings.

This warning is currently globally suppressed in Chromium, but this
suppression will be switched off, making a local suppression necessary.

BUG=505319
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/fb5b519030ef064e6b664c854cec1b90901350e4

[Matt Giuca, 2015-07-02 03:56:30]

mgiuca@chromium.org changed reviewers:
+ dpranke@chromium.org

[Matt Giuca, 2015-07-02 03:56:31]

I'm trying to get these warnings fixed upstream (see the two links in the
comment in the BUILD.gn file), but in the mean time, just suppressing the
warning suffices.

[Nico, 2015-07-02 05:08:32]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-02 05:08:32]

lgtm

[Matt Giuca, 2015-07-02 08:42:27]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-07-02 08:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 08:47:04]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Nico, 2015-07-02 15:06:16]

On 2015/07/02 08:47:04, commit-bot: I haz the power wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Huh, I thought the cq worked for ICU for me at some point. Try `git cl land` I
guess.

[Matt Giuca, 2015-07-03 04:22:54]

Committed patchset #2 (id:20001) manually as
fb5b519030ef064e6b664c854cec1b90901350e4 (presubmit successful).

[Peter Mayo, 2015-07-06 18:01:56]

petermayo@chromium.org changed reviewers:
+ petermayo@chromium.org

[Peter Mayo, 2015-07-06 18:01:57]

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
BUILD.gn:501: configs += [ ":icu_code" ]
Is this an accident?  It fails my gen rebuild.

[Nico, 2015-07-06 18:03:31]

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
BUILD.gn:501: configs += [ ":icu_code" ]
On 2015/07/06 18:01:56, Peter Mayo wrote:
> Is this an accident?  It fails my gen rebuild.

Yes, that looks like an accident (the same is added again the line below).

[Nico, 2015-07-06 18:04:29]

On 2015/07/06 18:03:31, Nico wrote:
> https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
> BUILD.gn:501: configs += [ ":icu_code" ]
> On 2015/07/06 18:01:56, Peter Mayo wrote:
> > Is this an accident?  It fails my gen rebuild.
> 
> Yes, that looks like an accident (the same is added again the line below).

(what does your build fail with? the bots are all happy. i'm going to fix it
since it's wrong, but i'm wondering why it fails for you but not the bots)

[Peter Mayo, 2015-07-06 18:06:58]

On 2015/07/06 18:04:29, Nico wrote:
> On 2015/07/06 18:03:31, Nico wrote:
> > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
> > BUILD.gn:501: configs += [ ":icu_code" ]
> > On 2015/07/06 18:01:56, Peter Mayo wrote:
> > > Is this an accident?  It fails my gen rebuild.
> > 
> > Yes, that looks like an accident (the same is added again the line below).
> 
> (what does your build fail with? the bots are all happy. i'm going to fix it
> since it's wrong, but i'm wondering why it fails for you but not the bots)

./out/local/gn gen out/linked
ERROR at //third_party/icu/BUILD.gn:503:16: Duplicate item in list
  configs += [ ":icu_code" ]
               ^----------
See //third_party/icu/BUILD.gn:501:16: This was the previous definition.
  configs += [ ":icu_code" ]
               ^----------
See //third_party/icu/BUILD.gn:310:1: whence it was called.
component("icuuc") {
^-------------------

[Peter Mayo, 2015-07-06 18:07:27]

On 2015/07/06 18:06:58, Peter Mayo wrote:
> On 2015/07/06 18:04:29, Nico wrote:
> > On 2015/07/06 18:03:31, Nico wrote:
> > > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
> > > File BUILD.gn (right):
> > > 
> > > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
> > > BUILD.gn:501: configs += [ ":icu_code" ]
> > > On 2015/07/06 18:01:56, Peter Mayo wrote:
> > > > Is this an accident?  It fails my gen rebuild.
> > > 
> > > Yes, that looks like an accident (the same is added again the line below).
> > 
> > (what does your build fail with? the bots are all happy. i'm going to fix it
> > since it's wrong, but i'm wondering why it fails for you but not the bots)
> 
> ./out/local/gn gen out/linked
> ERROR at //third_party/icu/BUILD.gn:503:16: Duplicate item in list
>   configs += [ ":icu_code" ]
>                ^----------
> See //third_party/icu/BUILD.gn:501:16: This was the previous definition.
>   configs += [ ":icu_code" ]
>                ^----------
> See //third_party/icu/BUILD.gn:310:1: whence it was called.
> component("icuuc") {
> ^-------------------

I'm using a really fresh (just built) gn, if that makes a sensitivity
difference.

[Nico, 2015-07-06 18:14:15]

On 2015/07/06 18:07:27, Peter Mayo wrote:
> On 2015/07/06 18:06:58, Peter Mayo wrote:
> > On 2015/07/06 18:04:29, Nico wrote:
> > > On 2015/07/06 18:03:31, Nico wrote:
> > > > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
> > > > File BUILD.gn (right):
> > > > 
> > > >
https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
> > > > BUILD.gn:501: configs += [ ":icu_code" ]
> > > > On 2015/07/06 18:01:56, Peter Mayo wrote:
> > > > > Is this an accident?  It fails my gen rebuild.
> > > > 
> > > > Yes, that looks like an accident (the same is added again the line
below).
> > > 
> > > (what does your build fail with? the bots are all happy. i'm going to fix
it
> > > since it's wrong, but i'm wondering why it fails for you but not the bots)
> > 
> > ./out/local/gn gen out/linked
> > ERROR at //third_party/icu/BUILD.gn:503:16: Duplicate item in list
> >   configs += [ ":icu_code" ]
> >                ^----------
> > See //third_party/icu/BUILD.gn:501:16: This was the previous definition.
> >   configs += [ ":icu_code" ]
> >                ^----------
> > See //third_party/icu/BUILD.gn:310:1: whence it was called.
> > component("icuuc") {
> > ^-------------------
> 
> I'm using a really fresh (just built) gn, if that makes a sensitivity
> difference.

Yes, that explains it. Chromium's DEPS doesn't pull in an ICU with this change
yet either – are you using some config that pulls icu head?

[Peter Mayo, 2015-07-06 18:18:02]

On 2015/07/06 18:14:15, Nico wrote:
> On 2015/07/06 18:07:27, Peter Mayo wrote:
> > On 2015/07/06 18:06:58, Peter Mayo wrote:
> > > On 2015/07/06 18:04:29, Nico wrote:
> > > > On 2015/07/06 18:03:31, Nico wrote:
> > > > > https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
> > > > > File BUILD.gn (right):
> > > > > 
> > > > >
> https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
> > > > > BUILD.gn:501: configs += [ ":icu_code" ]
> > > > > On 2015/07/06 18:01:56, Peter Mayo wrote:
> > > > > > Is this an accident?  It fails my gen rebuild.
> > > > > 
> > > > > Yes, that looks like an accident (the same is added again the line
> below).
> > > > 
> > > > (what does your build fail with? the bots are all happy. i'm going to
fix
> it
> > > > since it's wrong, but i'm wondering why it fails for you but not the
bots)
> > > 
> > > ./out/local/gn gen out/linked
> > > ERROR at //third_party/icu/BUILD.gn:503:16: Duplicate item in list
> > >   configs += [ ":icu_code" ]
> > >                ^----------
> > > See //third_party/icu/BUILD.gn:501:16: This was the previous definition.
> > >   configs += [ ":icu_code" ]
> > >                ^----------
> > > See //third_party/icu/BUILD.gn:310:1: whence it was called.
> > > component("icuuc") {
> > > ^-------------------
> > 
> > I'm using a really fresh (just built) gn, if that makes a sensitivity
> > difference.
> 
> Yes, that explains it. Chromium's DEPS doesn't pull in an ICU with this change
> yet either – are you using some config that pulls icu head?

Yes.

[Matt Giuca, 2015-07-07 03:15:53]

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1224463003/diff/20001/BUILD.gn#newcode501
BUILD.gn:501: configs += [ ":icu_code" ]
Oh no, looks like a rebase accident (wasn't a problem in PS1).

Looks like Nico has already fixed this in c81a1a3. Thanks, Nico.