Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: icu.gyp

Issue 1224463003: Suppress "unused-const-variable" Clang warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 '-Wno-tautological-compare', 288 '-Wno-tautological-compare',
289 # uresdata.c has switch(RES_GET_TYPE(x)) code. The 289 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
290 # RES_GET_TYPE macro returns an UResType enum, but some switch 290 # RES_GET_TYPE macro returns an UResType enum, but some switch
291 # statement contains case values that aren't part of that 291 # statement contains case values that aren't part of that
292 # enum (e.g. URES_TABLE32 which is in UResInternalType). This 292 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
293 # is on purpose. 293 # is on purpose.
294 '-Wno-switch', 294 '-Wno-switch',
295 # ICU has some code with the pattern: 295 # ICU has some code with the pattern:
296 # if (found = uprv_getWindowsTimeZoneInfo(...)) 296 # if (found = uprv_getWindowsTimeZoneInfo(...))
297 '-Wno-parentheses', 297 '-Wno-parentheses',
298 # ICU generally has no unused variables, but there are a few
299 # places where this warning triggers.
300 # See https://codereview.chromium.org/1222643002/ and
301 # http://www.icu-project.org/trac/ticket/11759.
302 "-Wno-unused-const-variable",
298 ], 303 ],
299 }, 304 },
300 'cflags': [ 305 'cflags': [
301 # Since ICU wants to internally use its own deprecated APIs, 306 # Since ICU wants to internally use its own deprecated APIs,
302 # don't complain about it. 307 # don't complain about it.
303 '-Wno-deprecated-declarations', 308 '-Wno-deprecated-declarations',
304 '-Wno-unused-function', 309 '-Wno-unused-function',
305 ], 310 ],
306 'cflags_cc': [ 311 'cflags_cc': [
307 '-frtti', 312 '-frtti',
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
591 }, 596 },
592 'includes': [ 597 'includes': [
593 '../../build/shim_headers.gypi', 598 '../../build/shim_headers.gypi',
594 ], 599 ],
595 'toolsets': ['target'], 600 'toolsets': ['target'],
596 }, 601 },
597 ], # targets 602 ], # targets
598 }], 603 }],
599 ], # conditions 604 ], # conditions
600 } 605 }
OLDNEW
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698