icu.gyp - Issue 1224463003: Suppress "unused-const-variable" Clang warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 1224463003: Suppress "unused-const-variable" Clang warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Rebase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: icu.gyp

diff --git a/icu.gyp b/icu.gyp

index 99662d1080347a9a07fafb676be390c9a59b8b9c..fb9dda035f691daf86d602e175441c5d5bf6b365 100644

--- a/icu.gyp

+++ b/icu.gyp

@@ -295,6 +295,11 @@

# ICU has some code with the pattern:

# if (found = uprv_getWindowsTimeZoneInfo(...))

'-Wno-parentheses',

+ # ICU generally has no unused variables, but there are a few

+ # places where this warning triggers.

+ # See https://codereview.chromium.org/1222643002/ and

+ # http://www.icu-project.org/trac/ticket/11759.

+ "-Wno-unused-const-variable",

'cflags': [

« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »