chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add HasWeakBrowserPointer protocol. Allow -dealloc without preceding -browserWillBeDestroyed. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h ('k') | chrome/browser/ui/cocoa/has_weak_browser_pointer.h » ('j') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

index 14b691b3e49bdb67be302238d566ccad4124586b..795415f90a5d7515e406fcfa995c3b378ffe679a 100644

--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

@@ -88,11 +88,16 @@ const float kRightEdgeOffset = 25;

}

- (void)dealloc {

+ [self browserWillBeDestroyed];

erikchen 2015/07/08 18:02:17 I recommended that you make a new method called -c

Robert Sesek 2015/07/08 22:15:18 I kind of agree, but I don't know if adding this e

+ [super dealloc];

+- (void)browserWillBeDestroyed {

// All animations should have been explicitly stopped before a tab is closed.

DCHECK(!showHideAnimation_.get());

DCHECK(!moveAnimation_.get());

[[NSNotificationCenter defaultCenter] removeObserver:self];

- [super dealloc];

+ browser_ = nullptr;

}

- (void)setFindBarBridge:(FindBarBridge*)findBarBridge {