chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add HasWeakBrowserPointer protocol. Allow -dealloc without preceding -browserWillBeDestroyed. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('j') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h

diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h

index 897c4a8929fb582a3fc4007b746f0396d3b0ed8e..93d698125431ab7bb7ee8dcf06a7b7877c8f74ce 100644

--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h

+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h

@@ -6,6 +6,7 @@

#include "base/mac/scoped_nsobject.h"

#include "base/strings/string16.h"

+#import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"

#include "ui/gfx/geometry/point.h"

class Browser;

@@ -20,7 +21,7 @@ class FindNotificationDetails;

// to the cross-platform FindBarController, so be sure to call

// setFindBarBridge: after creating this controller.

-@interface FindBarCocoaController : NSViewController {

+@interface FindBarCocoaController : NSViewController<HasWeakBrowserPointer> {

@private

IBOutlet NSView* findBarView_;

IBOutlet FindBarTextField* findText_;