chrome/browser/ui/cocoa/profiles/avatar_base_controller.h - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add HasWeakBrowserPointer protocol. Allow -dealloc without preceding -browserWillBeDestroyed. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm ('K') | « chrome/browser/ui/cocoa/has_weak_browser_pointer.h ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm » ('j') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

index 8e5ce6954c6fb3f17926e336dc0fb37cefa575c5..6a3330b762e6829eb23dacd2b589ea0e1b09f28a 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h

@@ -9,6 +9,7 @@

#import "base/mac/scoped_nsobject.h"

#include "base/memory/scoped_ptr.h"

+#import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"

erikchen 2015/07/08 18:02:17 ordering.

jackhou1 2015/07/09 03:48:02 Done.

#include "chrome/browser/ui/browser_window.h"

@class BaseBubbleController;

@@ -18,7 +19,7 @@ class ProfileInfoUpdateObserver;

// This view controller manages the button that sits in the top of the

// window frame when using multi-profiles, and shows information about the

// current profile. Clicking the button will open the profile menu.

-@interface AvatarBaseController : NSViewController {

+@interface AvatarBaseController : NSViewController<HasWeakBrowserPointer> {

@protected

Browser* browser_;