chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add HasWeakBrowserPointer protocol. Allow -dealloc without preceding -browserWillBeDestroyed. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_shelf_controller.mm ('K') | « chrome/browser/ui/cocoa/download/download_shelf_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.h » ('j') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

index 606b9acc39be94d69302ff49748336f19b6a1993..cbe05b38bb5ddb0c58f6ea5942d750a4ff81ca0e 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

@@ -121,7 +121,6 @@ class DownloadShelfControllerTest : public CocoaProfileTest {

void TearDown() override {

if (shelf_.get()) {

- [shelf_ exiting];

shelf_.reset();

}

CocoaProfileTest::TearDown();

@@ -374,7 +373,7 @@ TEST_F(DownloadShelfControllerTest, CancelAutoCloseOnExit) {

EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);

EXPECT_EQ(2, shelf_.get()->cancelAutoCloseCount_);

- [shelf_ exiting];

+ [shelf_ browserWillBeDestroyed];

erikchen 2015/07/08 18:02:17 Why does this need to be changed from -exiting?

jackhou1 2015/07/09 03:48:02 They do exactly the same thing. Essentially Downlo

EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);

EXPECT_EQ(3, shelf_.get()->cancelAutoCloseCount_);

shelf_.reset();