Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1221073004: Enable clang warning for ignored attributes. (Closed)

Created:
5 years, 5 months ago by benwells
Modified:
5 years, 5 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, jam, plaree+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable clang warning for ignored attributes. BUG=504695 Committed: https://crrev.com/e57417868063654250c8a6ee9e056218be654d95 Cr-Commit-Position: refs/heads/master@{#337420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M base/metrics/histogram_base.h View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/clear_mode.h View 1 chunk +1 line, -1 line 0 comments Download
M components/login/base_screen_handler_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_namespace.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/presentation_session.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/presentation_session_message.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_tcp_socket_shared.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/shutdown_reason.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/util/syncer_error.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_type_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221073004/1
5 years, 5 months ago (2015-07-02 08:47:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-02 10:50:15 UTC) #4
benwells
5 years, 5 months ago (2015-07-02 22:57:03 UTC) #6
Nico
cool, lgtm! so many exported enums :-/
5 years, 5 months ago (2015-07-02 23:38:54 UTC) #7
benwells
+brettw for owners
5 years, 5 months ago (2015-07-03 00:25:40 UTC) #9
Nico
On 2015/07/03 00:25:40, benwells wrote: > +brettw for owners (i looked at everything, so if ...
5 years, 5 months ago (2015-07-03 00:36:15 UTC) #10
benwells
ping brettw
5 years, 5 months ago (2015-07-06 02:58:53 UTC) #11
Nico
(thu/fri were a holiday in the us and now it's sunday, so there've been 0 ...
5 years, 5 months ago (2015-07-06 02:59:55 UTC) #12
benwells
On 2015/07/06 02:59:55, Nico wrote: > (thu/fri were a holiday in the us and now ...
5 years, 5 months ago (2015-07-06 03:46:10 UTC) #13
brettw
lgtm
5 years, 5 months ago (2015-07-06 16:57:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221073004/1
5 years, 5 months ago (2015-07-06 16:59:26 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 18:18:50 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 18:19:52 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e57417868063654250c8a6ee9e056218be654d95
Cr-Commit-Position: refs/heads/master@{#337420}

Powered by Google App Engine
This is Rietveld 408576698