Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: base/metrics/histogram_base.h

Issue 1221073004: Enable clang warning for ignored attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_ 5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_
6 #define BASE_METRICS_HISTOGRAM_BASE_H_ 6 #define BASE_METRICS_HISTOGRAM_BASE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 13 matching lines...) Expand all
24 class HistogramSamples; 24 class HistogramSamples;
25 class ListValue; 25 class ListValue;
26 class Pickle; 26 class Pickle;
27 class PickleIterator; 27 class PickleIterator;
28 28
29 //////////////////////////////////////////////////////////////////////////////// 29 ////////////////////////////////////////////////////////////////////////////////
30 // These enums are used to facilitate deserialization of histograms from other 30 // These enums are used to facilitate deserialization of histograms from other
31 // processes into the browser. If you create another class that inherits from 31 // processes into the browser. If you create another class that inherits from
32 // HistogramBase, add new histogram types and names below. 32 // HistogramBase, add new histogram types and names below.
33 33
34 enum BASE_EXPORT HistogramType { 34 enum HistogramType {
35 HISTOGRAM, 35 HISTOGRAM,
36 LINEAR_HISTOGRAM, 36 LINEAR_HISTOGRAM,
37 BOOLEAN_HISTOGRAM, 37 BOOLEAN_HISTOGRAM,
38 CUSTOM_HISTOGRAM, 38 CUSTOM_HISTOGRAM,
39 SPARSE_HISTOGRAM, 39 SPARSE_HISTOGRAM,
40 }; 40 };
41 41
42 std::string HistogramTypeToString(HistogramType type); 42 std::string HistogramTypeToString(HistogramType type);
43 43
44 // Create or find existing histogram that matches the pickled info. 44 // Create or find existing histogram that matches the pickled info.
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 private: 175 private:
176 const std::string histogram_name_; 176 const std::string histogram_name_;
177 int32_t flags_; 177 int32_t flags_;
178 178
179 DISALLOW_COPY_AND_ASSIGN(HistogramBase); 179 DISALLOW_COPY_AND_ASSIGN(HistogramBase);
180 }; 180 };
181 181
182 } // namespace base 182 } // namespace base
183 183
184 #endif // BASE_METRICS_HISTOGRAM_BASE_H_ 184 #endif // BASE_METRICS_HISTOGRAM_BASE_H_
OLDNEW
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698