build/config/compiler/BUILD.gn - Issue 1221073004: Enable clang warning for ignored attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1221073004: Enable clang warning for ignored attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index ad4d59d3976020615cf69f12b3c136e996dcc901..262b0f55dd56b4270616c7ccc2d8b09078d214b9 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -802,7 +802,6 @@ if (is_win) {

"-Wno-c++11-compat-deprecated-writable-strings", # http://crbug.com/504659

"-Wno-empty-body", # http://crbug.com/504661

"-Wno-extra-tokens", # http://crbug.com/504663

- "-Wno-ignored-attributes", # http://crbug.com/504695

"-Wno-incompatible-pointer-types", # http://crbug.com/504696

"-Wno-int-to-void-pointer-cast", # http://crbug.com/504697

"-Wno-invalid-noreturn", # http://crbug.com/504698

« no previous file with comments | « build/common.gypi ('k') | components/domain_reliability/clear_mode.h » ('j') | no next file with comments »