build/common.gypi - Issue 1221073004: Enable clang warning for ignored attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1221073004: Enable clang warning for ignored attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 00e0424b00509bebc839e363a932176c7da5a6b0..33addf50b2b6280d3bd4c2d4356fc2f148241246 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5703,7 +5703,6 @@

'-Wno-c++11-compat-deprecated-writable-strings', # http://crbug.com/504659

'-Wno-empty-body', # http://crbug.com/504661

'-Wno-extra-tokens', # http://crbug.com/504663

- '-Wno-ignored-attributes', # http://crbug.com/504695

'-Wno-incompatible-pointer-types', # http://crbug.com/504696

'-Wno-int-to-void-pointer-cast', # http://crbug.com/504697

'-Wno-invalid-noreturn', # http://crbug.com/504698

« no previous file with comments | « base/metrics/histogram_base.h ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »