Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1220363002: Remove duplicate icu_code config added in https://codereview.chromium.org/1224463003/ (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
Peter Mayo, Matt Giuca
CC:
chromium-reviews, Peter Mayo
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove duplicate icu_code config added in https://codereview.chromium.org/1224463003/ No intended behavior change (except fewer duplicated compiler flags). BUG=505319 TBR=mgiuca@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/c81a1a3989c3b66fa323e9a6ee7418d7c08297af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
5 years, 5 months ago (2015-07-06 18:06:47 UTC) #1
Nico
Committed patchset #1 (id:1) manually as c81a1a3989c3b66fa323e9a6ee7418d7c08297af (presubmit successful).
5 years, 5 months ago (2015-07-06 18:07:03 UTC) #2
Peter Mayo
5 years, 5 months ago (2015-07-06 18:07:55 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698