BUILD.gn - Issue 1220363002: Remove duplicate icu_code config added in https://codereview.chromium.org/1224463003/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1220363002: Remove duplicate icu_code config added in https://codereview.chromium.org/1224463003/ (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 19e2520c89f3dd2a9d2c3faee14408245b6ebadd..6a2312d0b16c7f937184e0f49596a49bbe45a257 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -500,7 +500,6 @@ component("icuuc") {

]

configs += [ ":icu_code" ]

- configs += [ ":icu_code" ]

public_configs = [ ":icu_config" ]

if (is_win || icu_use_data_file) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »