Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: BUILD.gn

Issue 1220363002: Remove duplicate icu_code config added in https://codereview.chromium.org/1224463003/ (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 configs -= [ 493 configs -= [
494 "//build/config/compiler:no_rtti", # ICU uses RTTI. 494 "//build/config/compiler:no_rtti", # ICU uses RTTI.
495 "//build/config/compiler:chromium_code", 495 "//build/config/compiler:chromium_code",
496 ] 496 ]
497 configs += [ 497 configs += [
498 "//build/config/compiler:rtti", 498 "//build/config/compiler:rtti",
499 "//build/config/compiler:no_chromium_code", 499 "//build/config/compiler:no_chromium_code",
500 ] 500 ]
501 configs += [ ":icu_code" ] 501 configs += [ ":icu_code" ]
502 502
503 configs += [ ":icu_code" ]
504 public_configs = [ ":icu_config" ] 503 public_configs = [ ":icu_config" ]
505 504
506 if (is_win || icu_use_data_file) { 505 if (is_win || icu_use_data_file) {
507 sources += [ "source/stubdata/stubdata.c" ] 506 sources += [ "source/stubdata/stubdata.c" ]
508 defines += [ "U_ICUDATAENTRY_IN_COMMON" ] 507 defines += [ "U_ICUDATAENTRY_IN_COMMON" ]
509 } 508 }
510 } 509 }
511 510
512 # TODO(GYP) support use_system_icu. 511 # TODO(GYP) support use_system_icu.
513 if (icu_use_data_file) { 512 if (icu_use_data_file) {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 sources = [ 570 sources = [
572 "android/icudtl_dat.S", 571 "android/icudtl_dat.S",
573 ] 572 ]
574 } else { 573 } else {
575 assert(false, "No icu data for this platform") 574 assert(false, "No icu data for this platform")
576 } 575 }
577 defines = [ "U_HIDE_DATA_SYMBOL" ] 576 defines = [ "U_HIDE_DATA_SYMBOL" ]
578 } 577 }
579 } 578 }
580 } 579 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698