Chromium Code Reviews
DescriptionMake popup menus line up to their baseline per the Material spec.
This entails:
- Making the baseline logic cache results.
- Making the baseline logic track who used its information.
- Making the baseline logic mark all ancestors up to whoever used
its information wheneven its node gets markNeedsLayout.
- Making RenderShrinkWrapWidth make its child respect the step width
and step height, rather than just sizing the child then snapping.
This is required to make the ink splashes render right on menus
that are snapped.
- Adding debugDescribeSettings() to RenderShrinkWrapWidth.
- Introducing a RenderBaseline class that offsets its child to a
certain baseline.
- Factoring out some common code from RenderBaseline and
RenderPositionedBox to RenderShiftedBox.
- Redoing all the menu layout logic.
BUG=
R=abarth@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/b5dcf78f609212eced8d6657182e9cc5e98619ce
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #
Total comments: 1
Patch Set 6 : #
Total comments: 1
Patch Set 7 : #
Messages
Total messages: 4 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||