Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: sky/sdk/lib/rendering/object.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/rendering/flex.dart ('k') | sky/sdk/lib/rendering/paragraph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/rendering/object.dart
diff --git a/sky/sdk/lib/rendering/object.dart b/sky/sdk/lib/rendering/object.dart
index 9624dc32ee022ec8246404ddd7c45fd39cbd9254..b384d029deb69cd6a74e850ff5500b1c7c57906b 100644
--- a/sky/sdk/lib/rendering/object.dart
+++ b/sky/sdk/lib/rendering/object.dart
@@ -69,8 +69,8 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
assert(!debugDoingPaint);
assert(child != null);
assert(child.parentData != null);
- child.parentData.detach();
child._cleanRelayoutSubtreeRoot();
+ child.parentData.detach();
super.dropChild(child);
markNeedsLayout();
}
@@ -122,7 +122,6 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
assert(parent == this.parent); // TODO(ianh): Remove this once the analyzer is cleverer
} else {
_nodesNeedingLayout.add(this);
- scheduler.ensureVisualUpdate();
}
}
void _cleanRelayoutSubtreeRoot() {
@@ -168,11 +167,12 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
_debugDoingThisLayout = false;
_debugCanParentUseSize = null;
} catch (e, stack) {
- print('Exception raised during layout of ${this}: ${e}');
+ print('Exception raised during layout:\n${e}\nContext:\n${this}');
print(stack);
return;
}
_needsLayout = false;
+ markNeedsPaint();
}
void layout(Constraints constraints, { bool parentUsesSize: false }) {
final parent = this.parent; // TODO(ianh): Remove this once the analyzer is cleverer
@@ -217,7 +217,7 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
//
// When calling layout() on your children, pass in
// "parentUsesSize: true" if your size or layout is dependent on
- // your child's size.
+ // your child's size or intrinsic dimensions.
// when the parent has rotated (e.g. when the screen has been turned
// 90 degrees), immediately prior to layout() being called for the
« no previous file with comments | « sky/sdk/lib/rendering/flex.dart ('k') | sky/sdk/lib/rendering/paragraph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698