Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Side by Side Diff: sky/sdk/lib/widgets/popup_menu_item.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | sky/specs/style-guide.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../painting/text_style.dart'; 5 import '../painting/text_style.dart';
6 import 'basic.dart'; 6 import 'basic.dart';
7 import 'default_text_style.dart'; 7 import 'default_text_style.dart';
8 import 'ink_well.dart'; 8 import 'ink_well.dart';
9 import 'theme.dart'; 9 import 'theme.dart';
10 10
11 const double kMenuItemHeight = 48.0;
12 const double kBaselineOffsetFromBottom = 20.0;
13
11 class PopupMenuItem extends Component { 14 class PopupMenuItem extends Component {
12 PopupMenuItem({ String key, this.child, this.opacity}) : super(key: key); 15 PopupMenuItem({ String key, this.child, this.opacity}) : super(key: key);
13 16
14 final Widget child; 17 final Widget child;
15 final double opacity; 18 final double opacity;
16 19
17 TextStyle get textStyle => Theme.of(this).text.subhead; 20 TextStyle get textStyle => Theme.of(this).text.subhead;
18 21
19 Widget build() { 22 Widget build() {
20 return new Opacity( 23 return new Opacity(
21 opacity: opacity, 24 opacity: opacity,
22 child: new InkWell( 25 child: new InkWell(
23 child: new Container( 26 child: new Container(
24 height: 48.0, 27 height: kMenuItemHeight,
25 child: new DefaultTextStyle( 28 child: new DefaultTextStyle(
26 style: textStyle, 29 style: textStyle,
27 child: child 30 child: new Baseline(
31 baseline: kMenuItemHeight - kBaselineOffsetFromBottom,
32 child: child
33 )
28 ) 34 )
29 ) 35 )
30 ) 36 )
31 ); 37 );
32 } 38 }
33 } 39 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | sky/specs/style-guide.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698