Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: sky/specs/style-guide.md

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu_item.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/style-guide.md
diff --git a/sky/specs/style-guide.md b/sky/specs/style-guide.md
index 123acd453eb91acbb0b43a1dbd59332dd9ccc1d1..e475fa810ab17d3ea8e5dda1654d6f24adfea61b 100644
--- a/sky/specs/style-guide.md
+++ b/sky/specs/style-guide.md
@@ -87,16 +87,16 @@ the expression, even if it is short. (Doing so makes it unobvious that
there is relevant code there. This is especially important for early
returns.)
-If a flow control structure has just one statement, then don't use
-braces around it except where doing so would help readability or avoid
-the dangling-else problem. Keeping the code free of boilerplate or
-redundant punctuation keeps it concise and readable.
+If a flow control structure's statement is one line long, then don't
+use braces around it. (Keeping the code free of boilerplate or
+redundant punctuation keeps it concise and readable.)
> For example,
> ```dart
-> if (children != null)
+> if (children != null) {
> for (RenderBox child in children)
> add(child);
+> }
> ```
> ...rather than:
> ```dart
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu_item.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698