Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217573002: remove SkInstCnt (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove SkInstCnt It's been outclassed by Valgrind and leak sanitizer, and it seems to be causing problems for external folks building Skia. I'm not sure why our own builds seem unaffected. Latest thread: https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0 BUG=skia: Committed: https://skia.googlesource.com/skia/+/2766c00fc0b6a07d46e5f74cdad45da2ef625237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -391 lines) Patch
M bench/Benchmark.h View 1 chunk +0 lines, -2 lines 0 comments Download
M bench/GrResourceCacheBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/RefCntBench.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M dm/DM.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M experimental/PdfViewer/SkNulCanvas.h View 2 chunks +1 line, -3 lines 0 comments Download
M experimental/PdfViewer/SkTrackDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/gm_expectations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkColorTable.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDataTable.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDocument.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDrawFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDrawLooper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkImage.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/core/SkImageDecoder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkImageFilter.h View 3 chunks +2 lines, -4 lines 0 comments Download
D include/core/SkInstCnt.h View 1 chunk +0 lines, -82 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPath.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/core/SkPathEffect.h View 4 chunks +3 lines, -5 lines 0 comments Download
M include/core/SkPathRef.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -17 lines 0 comments Download
M include/core/SkRasterizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkRefCnt.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkStream.h View 7 chunks +0 lines, -13 lines 0 comments Download
M include/core/SkSurface.h View 3 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkTypeface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkWeakRefCnt.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkXfermode.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrCaps.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/gpu/GrContext.h View 7 chunks +6 lines, -8 lines 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/gpu/GrGpuResource.h View 4 chunks +2 lines, -5 lines 0 comments Download
M include/gpu/GrGpuResourceRef.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrPathRendererChain.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrProcessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrProgramElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrSurface.h View 3 chunks +3 lines, -5 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/images/SkMovie.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontMgr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/ports/SkRemotableFontMgr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/utils/SkBoundaryPatch.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkEventSink.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/views/animated/SkWidgetViews.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBBoxHierarchy.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapHeap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDeviceProfile.h View 1 chunk +1 line, -1 line 0 comments Download
D src/core/SkInstCnt.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M src/core/SkMaskGamma.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPtrRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRTree.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrFontScaler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrGeometryBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPath.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRange.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencilAttachment.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkCachingPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFStream.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFTypes.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkRemotableFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrMemoryPoolTest.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M tests/LListTest.cpp View 7 chunks +1 line, -30 lines 0 comments Download
M tests/RefDictTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/UtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M tools/bench_pictures_main.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/filtermain.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217573002/1
5 years, 5 months ago (2015-06-26 18:28:21 UTC) #2
mtklein_C
5 years, 5 months ago (2015-06-26 18:34:26 UTC) #4
reed1
lgtm
5 years, 5 months ago (2015-06-26 18:36:45 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-26 18:37:01 UTC) #9
robertphillips
lgtm
5 years, 5 months ago (2015-06-26 18:42:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217573002/1
5 years, 5 months ago (2015-06-26 18:43:23 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 18:45:07 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2766c00fc0b6a07d46e5f74cdad45da2ef625237

Powered by Google App Engine
This is Rietveld 408576698