Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216433005: style nit cleanups. e.g. remove 'virtual' on override declarations (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

style nit cleanups. e.g. remove 'virtual' on override declarations Committed: https://skia.googlesource.com/skia/+/31dc1b2db0f04e68e540ebc339c8bde0978e5b97

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M include/effects/SkBitmapSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +7 lines, -7 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorShader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 3 chunks +15 lines, -9 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
robertphillips
5 years, 5 months ago (2015-07-07 14:13:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433005/1
5 years, 5 months ago (2015-07-07 14:13:59 UTC) #4
jvanverth1
lgtm
5 years, 5 months ago (2015-07-07 14:20:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433005/1
5 years, 5 months ago (2015-07-07 15:08:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/883)
5 years, 5 months ago (2015-07-07 15:09:15 UTC) #10
robertphillips
Mike - can you take a look?
5 years, 5 months ago (2015-07-07 15:10:01 UTC) #12
reed1
how about "style nit cleanups. e.g. remove 'virtual' on override declarations" https://codereview.chromium.org/1216433005/diff/1/src/core/SkXfermode_proccoeff.h File src/core/SkXfermode_proccoeff.h (right): ...
5 years, 5 months ago (2015-07-07 15:23:35 UTC) #13
robertphillips
Updated description https://codereview.chromium.org/1216433005/diff/1/src/core/SkXfermode_proccoeff.h File src/core/SkXfermode_proccoeff.h (right): https://codereview.chromium.org/1216433005/diff/1/src/core/SkXfermode_proccoeff.h#newcode2 src/core/SkXfermode_proccoeff.h:2: * Copyright 2015 The Android Open Source ...
5 years, 5 months ago (2015-07-07 16:35:51 UTC) #14
reed1
lgtm
5 years, 5 months ago (2015-07-07 16:37:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433005/20001
5 years, 5 months ago (2015-07-07 16:55:43 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 17:05:21 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/31dc1b2db0f04e68e540ebc339c8bde0978e5b97

Powered by Google App Engine
This is Rietveld 408576698